Calculated Variable Celsius to Fahrenheit DS18

This topic has 14 replies, 2 voices, and was last updated 2021-02-15 at 11:27 AM by Sara Damiano.

Viewing 14 reply threads

Author

Posts

2021-02-12 at 11:54 AM #15133

Participant

My problem is that during compilation I get the error below.
I’m trying to convert the Celsius reading from my DS18 to Fahrenheit by using the baro_rho_correction sketch as a guide. I feel like

My problem is that during compilation I get the error below.
I’m trying to convert the Celsius reading from my DS18 to Fahrenheit by using the baro_rho_correction sketch as a guide. I feel like I’ve got the calculated variable code copied over right as far as I can tell but something’s still wrong in the 186 to 240 line range.
I have included the sketch that I’m working on.

C:/Users/brian.jastram/Documents/GitHub/Dev/WXMMBME280OLEDFtoC/WXMMBME280OLEDFtoC.ino:237:9: error: expected type-specifier before 'CalcTempF'
     new CalcTempF(&ds18, "12345689-abcd-1234-ef00-1234567890ab"),
         ^
C:/Users/brian.jastram/Documents/GitHub/Dev/WXMMBME280OLEDFtoC/WXMMBME280OLEDFtoC.ino:237:9: error: expected '}' before 'CalcTempF'
C:/Users/brian.jastram/Documents/GitHub/Dev/WXMMBME280OLEDFtoC/WXMMBME280OLEDFtoC.ino:237:9: error: expected ',' or ';' before 'CalcTempF'
C:/Users/brian.jastram/Documents/GitHub/Dev/WXMMBME280OLEDFtoC/WXMMBME280OLEDFtoC.ino:240:1: error: expected declaration before '}' token
 };
 ^
*** [.pio\build\mayfly\src\WXMMBME280OLEDFtoC.ino.cpp.o] Error 1
========================== [FAILED] Took 5.85 seconds ==========================

C:/Users/brian.jastram/Documents/GitHub/Dev/WXMMBME280OLEDFtoC/WXMMBME280OLEDFtoC.ino:237:9: error: expected type-specifier before 'CalcTempF'

new CalcTempF(&ds18, "12345689-abcd-1234-ef00-1234567890ab"),

C:/Users/brian.jastram/Documents/GitHub/Dev/WXMMBME280OLEDFtoC/WXMMBME280OLEDFtoC.ino:237:9: error: expected '}' before 'CalcTempF'

C:/Users/brian.jastram/Documents/GitHub/Dev/WXMMBME280OLEDFtoC/WXMMBME280OLEDFtoC.ino:237:9: error: expected ',' or ';' before 'CalcTempF'

C:/Users/brian.jastram/Documents/GitHub/Dev/WXMMBME280OLEDFtoC/WXMMBME280OLEDFtoC.ino:240:1: error: expected declaration before '}' token

};

*** [.pio\build\mayfly\src\WXMMBME280OLEDFtoC.ino.cpp.o] Error 1

========================== [FAILED] Took 5.85 seconds ==========================

/*****************************************************************************
Based on logging_to MMW.ino
Adapted by Anthony and Brian
from source by:  Sara Damiano (sdamiano@stroudcenter.org)
Development Environment: PlatformIO
Hardware Platform: EnviroDIY Mayfly Arduino Datalogger
Software License: BSD-3.
  Copyright (c) 2017, Stroud Water Research Center (SWRC)
  and the EnviroDIY Development Team

This example sketch is written for ModularSensors library version 0.23.4

This shows most of the standard functions of the library at once.

DISCLAIMER:
THIS CODE IS PROVIDED "AS IS" - NO WARRANTY IS GIVEN.
*****************************************************************************/

// ==========================================================================
//    Defines for the Arduino IDE
//    In PlatformIO, set these build flags in your platformio.ini
// ==========================================================================
#ifndef TINY_GSM_RX_BUFFER
#define TINY_GSM_RX_BUFFER 512
#endif
#ifndef TINY_GSM_YIELD_MS
#define TINY_GSM_YIELD_MS 2
#endif
#ifndef MQTT_MAX_PACKET_SIZE
#define MQTT_MAX_PACKET_SIZE 240
#endif

// ==========================================================================
//    Include the base required libraries
// ==========================================================================
#include <Arduino.h>  // The base Arduino library
#include <EnableInterrupt.h>  // for external and pin change interrupts
#include <LoggerBase.h>  // The modular sensors library

// ==========================================================================
//    Include libraries for OLED
// ==========================================================================
#include <Wire.h>
#include <SPI.h>
#include <Adafruit_Sensor.h>
#include <Adafruit_BME280.h>
#include <SDL_Arduino_SSD1306.h>    // Modification of Adafruit_SSD1306 for ESP8266 compatibility
#include <AMAdafruit_GFX.h>   // Needs a little change in original Adafruit library (See README.txt file)
#include <SPI.h>            // For SPI comm (needed for not getting compile error)

// Create an instance of the OLED display
SDL_Arduino_SSD1306 display(4); // FOR I2C

#define SEALEVELPRESSURE_HPA (1013.25)

Adafruit_BME280 bme; // I2C

// ==========================================================================
//    Data Logger Settings
// ==========================================================================
// The library version this example was written for|previously 0.23.11
const char *libraryVersion = "0.25.1";
// The name of this file
const char *sketchName = "WXSTN_Mini_Mobile.ino";
// Logger ID, also becomes the prefix for the name of the data file on SD card
const char *LoggerID = "WX001";
// How frequently (in minutes) to log data
const uint8_t loggingInterval = 15;
// Your logger's timezone.
const int8_t timeZone = -6;  // Central Standard Time
// NOTE:  Daylight savings time will not be applied!  Please use standard time!

// ==========================================================================
//    Primary Arduino-Based Board and Processor
// ==========================================================================
#include <sensors/ProcessorStats.h>

const long serialBaud = 115200;   // Baud rate for the primary serial port for debugging
const int8_t greenLED = 8;        // MCU pin for the green LED (-1 if not applicable)
const int8_t redLED = 9;          // MCU pin for the red LED (-1 if not applicable)
const int8_t buttonPin = 21;      // MCU pin for a button to use to enter debugging mode  (-1 if not applicable)
const int8_t wakePin = A7;        // MCU interrupt/alarm pin to wake from sleep
// Set the wake pin to -1 if you do not want the main processor to sleep.
// In a SAMD system where you are using the built-in rtc, set wakePin to 1
const int8_t sdCardPwrPin = -1;     // MCU SD card power pin (-1 if not applicable)
const int8_t sdCardSSPin = 12;      // MCU SD card chip select/slave select pin (must be given!)
const int8_t sensorPowerPin = 22;  // MCU pin controlling main sensor power (-1 if not applicable)

// Create the main processor chip "sensor" - for general metadata
const char *mcuBoardVersion = "v0.5b";
ProcessorStats mcuBoard(mcuBoardVersion);

// ==========================================================================
//    Wifi/Cellular Modem Settings
// ==========================================================================

// Create a reference to the serial port for the modem
// Extra hardware and software serial ports are created in the "Settings for Additional Serial Ports" section
HardwareSerial &modemSerial = Serial1;  // Use hardware serial if possible
// AltSoftSerial &modemSerial = altSoftSerial;  // For software serial if needed
// NeoSWSerial &modemSerial = neoSSerial1;  // For software serial if needed

// Modem Pins - Describe the physical pin connection of your modem to your board
const int8_t modemVccPin = -2;      // MCU pin controlling modem power (-1 if not applicable)
const int8_t modemStatusPin = 19;   // MCU pin used to read modem status (-1 if not applicable)
const int8_t modemResetPin = 20;    // MCU pin connected to modem reset pin (-1 if unconnected)
const int8_t modemSleepRqPin = 23;  // MCU pin used for modem sleep/wake request (-1 if not applicable)
const int8_t modemLEDPin = redLED;  // MCU pin connected an LED to show modem status (-1 if unconnected)

// Network connection information
const char *apn = "hologram";  // The APN for the gprs connection

#if not defined MS_BUILD_TESTING || defined MS_BUILD_TEST_XBEE_CELLULAR
// For any Digi Cellular XBee's
// NOTE:  The u-blox based Digi XBee's (3G global and LTE-M global)
// are more stable used in bypass mode (below)
// The Telit based Digi XBees (LTE Cat1) can only use this mode.
#include <modems/DigiXBeeCellularTransparent.h>
const long modemBaud = 9600;  // All XBee's use 9600 by default
const bool useCTSforStatus = false;   // Flag to use the modem CTS pin for status
// NOTE:  If possible, use the STATUS/SLEEP_not (XBee pin 13) for status, but
// the CTS pin can also be used if necessary
DigiXBeeCellularTransparent modemXBCT(&modemSerial,
                                      modemVccPin, modemStatusPin, useCTSforStatus,
                                      modemResetPin, modemSleepRqPin,
                                      apn);
// Create an extra reference to the modem by a generic name (not necessary)
DigiXBeeCellularTransparent modem = modemXBCT;

#endif

// ==========================================================================
//    Maxim DS3231 RTC (Real Time Clock)
// ==========================================================================
#include <sensors/MaximDS3231.h>

// ==========================================================================
//    Bosch BME280 Environmental Sensor (Temperature, Humidity, Pressure)
// ==========================================================================
#include <sensors/BoschBME280.h>

const int8_t I2CPower = sensorPowerPin;  // Pin to switch power on and off (-1 if unconnected)
uint8_t BMEi2c_addr = 0x77;
// The BME280 can be addressed either as 0x77 (Adafruit default) or 0x76 (Grove default)
// Either can be physically mofidied for the other address

// Create a Bosch BME280 sensor object
BoschBME280 bme280(I2CPower, BMEi2c_addr);

// Create four variable pointers for the BME280
Variable *bme280Humid = new BoschBME280_Humidity(&bme280, "12345678-abcd-1234-ef00-1234567890ab");
Variable *bme280Temp = new BoschBME280_Temp(&bme280, "12345678-abcd-1234-ef00-1234567890ab");
Variable *bme280Press = new BoschBME280_Pressure(&bme280, "12345678-abcd-1234-ef00-1234567890ab");
Variable *bme280Alt = new BoschBME280_Altitude(&bme280, "12345678-abcd-1234-ef00-1234567890ab");
// Variable *bme280TempF = new CalcTempF(&bme280, "12345689-abcd-1234-ef00-1234567890ab");

// Create a DS3231 sensor object
MaximDS3231 ds3231(1);

// ==========================================================================
//    Maxim DS18 One Wire Temperature Sensor
// ==========================================================================
#include <sensors/MaximDS18.h>

// OneWire Address [array of 8 hex characters]
// If only using a single sensor on the OneWire bus, you may omit the address
// DeviceAddress OneWireAddress1 = {0x28, 0xFF, 0xBD, 0xBA, 0x81, 0x16, 0x03, 0x0C};
const int8_t OneWirePower = sensorPowerPin;  // Pin to switch power on and off (-1 if unconnected)
const int8_t OneWireBus = 7;  // Pin attached to the OneWire Bus (-1 if unconnected) (D24 = A0)

// Create a Maxim DS18 sensor objects (use this form for a known address)
MaximDS18 ds18(OneWirePower, OneWireBus);

// Create a Maxim DS18 sensor object (use this form for a single sensor on bus with an unknown address)
// MaximDS18 ds18(OneWirePower, OneWireBus);

// Create a temperature variable pointer for the DS18
Variable *ds18Temp = new MaximDS18_Temp(&ds18, "12345678-abcd-1234-ef00-1234567890ab");


// ==========================================================================
//    Calculated Variables
// ==========================================================================
// Create the function to convert the BME280 celcius to fahrenheit
// Variable *bme280TempF = new BoshBME280_TempF(&bme280, "12345689-abcd-1234-ef00-1234567890ab");
float calculateTempF(void)
{
    float TempCFromMaximDS18_Temp = ds18Temp->getValue();
    float TempF = TempCFromMaximDS18_Temp*(1.8)+32;
    if (TempCFromMaximDS18_Temp == -9999)
    {
        TempF = -9999;
    }
    return TempF;
}
// Properties of the calculated temperature variable
const char *TempFVarName = "Temperature";
const char *TempFVarUnit = "Degree";
int TempFVarResolution = 2;
const char *TempFUUID = "12345678-abcd-1234-ef00-1234567890ab";
const char *TempFVarCode = "CalcTempF";
// Create the calculated fahrenheit variable object and return a variable pointer to it
Variable *CalcTempF = new Variable(calculateTempF, TempFVarResolution,
                                   TempFVarName, TempFVarUnit,
                                   TempFVarCode, TempFUUID);

/* CtoF - example from the internet
float CtoF(float cel){
  float fahrenheit = (cel * 1.8) + 32;
  return fahrenheit;
}

void printValues() {
    Serial.print("Temperature = ");
    float cel = bme.readTemperature();
    Serial.print (bme.readTemperature());
    Serial.println("C");
    Serial.print(CtoF(cel));
    Serial.println("F");
}
 End CtoF - example from internet*/

// ==========================================================================
//    Creating the Variable Array[s] and Filling with Variable Objects
// ==========================================================================

Variable *variableList[] = {
    // new ProcessorStats_SampleNumber(&mcuBoard, "12345678-abcd-1234-ef00-1234567890ab"),
    new ProcessorStats_Battery(&mcuBoard, "b17cb0f2-5538-4790-8641-39f416d185a3"),
    new Modem_RSSI(&modem, "e1788d85-f8ca-451f-af49-5d4068650a04"),
    new Modem_SignalPercent(&modem, "94c67feb-ade1-42eb-aef2-dcb021b85ef4"),
    // new MaximDS3231_Temp(&ds3231, "3a304193-2e51-49e8-96a5-41015b445484"),
    // new RainCounterI2C_Tips(&tbi2c, "12345678-abcd-1234-ef00-1234567890ab"),
    new MaximDS18_Temp(&ds18, "a212b5a8-8ab3-456a-8e0e-c8647fe81772"),
    new BoschBME280_Humidity(&bme280, "fb3cb409-fdc3-42e4-9881-2ee06ad4a4d7"),
    new BoschBME280_Temp(&bme280, "d7b3ba33-8742-4c91-ac2e-8042e76b8f61"),
    new CalcTempF(&ds18, "12345689-abcd-1234-ef00-1234567890ab"),
    new BoschBME280_Pressure(&bme280, "252df794-5f34-4d70-b275-9a908c905b18"),
    new BoschBME280_Altitude(&bme280, "09fe0223-e9ea-4937-93d7-3468bad920cd"),
};

// Count up the number of pointers in the array
int variableCount = sizeof(variableList) / sizeof(variableList[0]);

// Create the VariableArray object
VariableArray varArray(variableCount, variableList);

// ==========================================================================
//     The Logger Object[s]
// ==========================================================================

// Create a new logger instance
Logger dataLogger(LoggerID, loggingInterval, &varArray);

// ==========================================================================
//    A Publisher to Monitor My Watershed / EnviroDIY Data Sharing Portal
// ==========================================================================
// Device registration and sampling feature information can be obtained after
// registration at https://monitormywatershed.org or https://data.envirodiy.org
const char *registrationToken = "ffb78d86-af9e-426d-ad44-b807f9e0cd4a";   // Device registration token
const char *samplingFeature = "f5290c01-05a9-4047-b096-ca21f21bfbdd";     // Sampling feature UUID

// Create a data publisher for the EnviroDIY/WikiWatershed POST endpoint
#include <publishers/EnviroDIYPublisher.h>
EnviroDIYPublisher EnviroDIYPOST(dataLogger, &modem.gsmClient, registrationToken, samplingFeature);

// ==========================================================================
//    Working Functions
// ==========================================================================

// Flashes the LED's on the primary board
void greenredflash(uint8_t numFlash = 4, uint8_t rate = 75)
{
    for (uint8_t i = 0; i < numFlash; i++) {
        digitalWrite(greenLED, HIGH);
        digitalWrite(redLED, LOW);
        delay(rate);
        digitalWrite(greenLED, LOW);
        digitalWrite(redLED, HIGH);
        delay(rate);
    }
    digitalWrite(redLED, LOW);
}

// Read's the battery voltage
// NOTE: This will actually return the battery level from the previous update!
float getBatteryVoltage()
{
    if (mcuBoard.sensorValues[0] == -9999) mcuBoard.update();
    return mcuBoard.sensorValues[0];
}

unsigned long delayTime;

// ==========================================================================
// Main setup function
// ==========================================================================
void setup()
{
    // Wait for USB connection to be established by PC
    // NOTE:  Only use this when debugging - if not connected to a PC, this
    // could prevent the script from starting
    // #if defined SERIAL_PORT_USBVIRTUAL
    //   while (!SERIAL_PORT_USBVIRTUAL && (millis() < 10000)){}
    // #endif

    // Start the primary serial connection
    Serial.begin(serialBaud);
    //Added from Example_06_Mayfly_BME280_OLED START
    //Serial.println(F("BME280 test"));

    // pinMode(5, INPUT);
    pinMode(5, INPUT);
    display.begin(SSD1306_SWITCHCAPVCC, 0x3C, false);  // initialize with the I2C addr 0x3C (for the 128x64)
    /**
    display.clearDisplay();
    display.setTextSize(2);
    display.setTextColor(WHITE);
    display.setCursor(0,0);
    display.println("Mayfly");
    display.println("BME280 DEMO...");
    display.display();
    /**
    display.begin(SSD1306_SWITCHCAPVCC, 0x3C, false);  // initialize with the I2C addr 0x3C (for the 128x64)
    display.clearDisplay();
    display.setTextSize(1);
    display.setTextColor(WHITE, BLACK);
    display.setTextColor(WHITE);
    display.setCursor(0,0);
    display.println("Mobile Mini Weather");
    display.println("What's the Temp?");
    display.println("*");
    display.setTextSize(1);
    display.setTextColor(WHITE, BLACK);
    display.println("MMWX 808");
    display.println("Location Unknown");
    display.setTextSize(2);
    display.println("72 degrees and sunny");
    display.println("hi");
    display.display();
    **/
    // Turn on switched power
    pinMode(I2CPower, OUTPUT);
    digitalWrite(I2CPower, HIGH);

    bool status;

    // default settings
    // (you can also pass in a Wire library object like &Wire2)
    status = bme.begin(BMEi2c_addr);
    if (!status) {
        Serial.println("Could not find a valid BME280 sensor, check wiring!");
        while (1);
    }
/**
    Serial.println("-- Timing Test --");
    delayTime = 1100;

    Serial.println();

    // Print table headers
    Serial.println("  Time,  Temp, Humid,   Press,   Alt");
    Serial.println("    ms,    *C,     %,      Pa,     m");
    //END added from Example_06_Mayfly_BME280_OLED
**/
    // Print a start-up note to the first serial port
    Serial.print(F("Now running "));
    Serial.print(sketchName);
    Serial.print(F(" on Logger "));
    Serial.println(LoggerID);
    Serial.println();

    Serial.print(F("Using ModularSensors Library version "));
    Serial.println(MODULAR_SENSORS_VERSION);

    if (String(MODULAR_SENSORS_VERSION) !=  String(libraryVersion))
        Serial.println(F(
            "WARNING: THIS EXAMPLE WAS WRITTEN FOR A DIFFERENT VERSION OF MODULAR SENSORS!!"));

    // Allow interrupts for software serial
    #if defined SoftwareSerial_ExtInts_h
        enableInterrupt(softSerialRx, SoftwareSerial_ExtInts::handle_interrupt, CHANGE);
    #endif
    #if defined NeoSWSerial_h
        enableInterrupt(neoSSerial1Rx, neoSSerial1ISR, CHANGE);
    #endif

    // Start the serial connection with the modem
    modemSerial.begin(modemBaud);


    // Set up pins for the LED's
    pinMode(greenLED, OUTPUT);
    digitalWrite(greenLED, LOW);
    pinMode(redLED, OUTPUT);
    digitalWrite(redLED, LOW);
    // Blink the LEDs to show the board is on and starting up
    greenredflash();

    // Set up some of the power pins so the board boots up with them off
    // NOTE:  This isn't necessary at all.  The logger begin() function
    // should leave all power pins off when it finishes.

    /**
    if (modemVccPin >= 0)
    {
        pinMode(modemVccPin, OUTPUT);
        digitalWrite(modemVccPin, LOW);
    }
    if (sensorPowerPin >= 0)
    {
        pinMode(sensorPowerPin, OUTPUT);
        digitalWrite(sensorPowerPin, LOW);
    }
    **/

    // Set the timezones for the logger/data and the RTC
    // Logging in the given time zone
    Logger::setLoggerTimeZone(timeZone);
    // It is STRONGLY RECOMMENDED that you set the RTC to be in UTC (UTC+0)
    Logger::setRTCTimeZone(-6);

    // Attach the modem and information pins to the logger
    dataLogger.attachModem(modem);
    modem.setModemLED(modemLEDPin);
    dataLogger.setLoggerPins(wakePin, sdCardSSPin, sdCardPwrPin, buttonPin, greenLED);

    // Begin the logger
    dataLogger.begin();

    // Note:  Please change these battery voltages to match your battery
    // Check that the battery is OK before powering the modem
    if (getBatteryVoltage() > 3.7)
    {
        modem.modemPowerUp();
        modem.wake();
        modem.setup();

        // At very good battery voltage, or with suspicious time stamp, sync the clock
        // Note:  Please change these battery voltages to match your battery
        if (getBatteryVoltage() > 3.8 ||
            dataLogger.getNowEpoch() < 1546300800 ||  /*Before 01/01/2019*/
            dataLogger.getNowEpoch() > 1735689600)  /*After 1/1/2025*/
        {
            // Synchronize the RTC with NIST
            Serial.println(F("Attempting to connect to the internet and synchronize RTC with NIST"));
            if (modem.connectInternet(120000L))
            {
                dataLogger.setRTClock(modem.getNISTTime());
            }
            else
            {
                Serial.println(F("Could not connect to internet for clock sync."));
            }
        }
    }

    // Set up the sensors, except at lowest battery level
    if (getBatteryVoltage() > 3.4)
    {
        Serial.println(F("Setting up sensors..."));
        varArray.setupSensors();
    }

    // Power down the modem
    modem.disconnectInternet();
    modem.modemSleepPowerDown();

    // Create the log file, adding the default header to it
    // Do this last so we have the best chance of getting the time correct and
    // all sensor names correct
    // Writing to the SD card can be power intensive, so if we're skipping
    // the sensor setup we'll skip this too.
    if (getBatteryVoltage() > 3.4)
    {
        dataLogger.turnOnSDcard(true);  // true = wait for card to settle after power up
        dataLogger.createLogFile(true);  // true = write a new header
        dataLogger.turnOffSDcard(true);  // true = wait for internal housekeeping after write
    }
    // Call the processor sleep
    Serial.println(F("Putting processor to sleep"));
    dataLogger.systemSleep();
}


// ==========================================================================
// Main loop function
// ==========================================================================

// Use this short loop for simple data logging and sending
void loop()
{
  if (getBatteryVoltage() > 3.6)
  //    for (int i=0; i <= 30; i++)
  {
      display.clearDisplay();
      display.setTextSize(2);
      display.setTextColor(WHITE);
      display.setCursor(0,0);
      // display.print("T: "); display.print(sensors.getTempCByIndex(0)); display.println(" C");
      display.print("T: "); display.print(bme.readTemperature()); display.println(" C");
      display.print("H: "); display.print(bme.readHumidity()); display.println(" %");
      display.print("E:"); display.print(bme.readAltitude(SEALEVELPRESSURE_HPA)); display.println(" M");
      display.setTextSize(1);
      display.print("P: "); display.print(bme.readPressure()); display.println(" Pa");
      display.display();
    }
    // Note:  Please change these battery voltages to match your battery
    // At very low battery, just go back to sleep
    if (getBatteryVoltage() < 3.4)
    {
        dataLogger.systemSleep();
    }
    // At moderate voltage, log data but don't send it over the modem
    else if (getBatteryVoltage() < 3.6)
    {
        dataLogger.logData();
    }
    // If the battery is good, send the data to the world
    else
    {
        dataLogger.logDataAndPublish();
    }

}

100

101

102

103

104

105

106

107

108

109

110

111

112

113

114

115

116

117

118

119

120

121

122

123

124

125

126

127

128

129

130

131

132

133

134

135

136

137

138

139

140

141

142

143

144

145

146

147

148

149

150

151

152

153

154

155

156

157

158

159

160

161

162

163

164

165

166

167

168

169

170

171

172

173

174

175

176

177

178

179

180

181

182

183

184

185

186

187

188

189

190

191

192

193

194

195

196

197

198

199

200

201

202

203

204

205

206

207

208

209

210

211

212

213

214

215

216

217

218

219

220

221

222

223

224

225

226

227

228

229

230

231

232

233

234

235

236

237

238

239

240

241

242

243

244

245

246

247

248

249

250

251

252

253

254

255

256

257

258

259

260

261

262

263

264

265

266

267

268

269

270

271

272

273

274

275

276

277

278

279

280

281

282

283

284

285

286

287

288

289

290

291

292

293

294

295

296

297

298

299

300

301

302

303

304

305

306

307

308

309

310

311

312

313

314

315

316

317

318

319

320

321

322

323

324

325

326

327

328

329

330

331

332

333

334

335

336

337

338

339

340

341

342

343

344

345

346

347

348

349

350

351

352

353

354

355

356

357

358

359

360

361

362

363

364

365

366

367

368

369

370

371

372

373

374

375

376

377

378

379

380

381

382

383

384

385

386

387

388

389

390

391

392

393

394

395

396

397

398

399

400

401

402

403

404

405

406

407

408

409

410

411

412

413

414

415

416

417

418

419

420

421

422

423

424

425

426

427

428

429

430

431

432

433

434

435

436

437

438

439

440

441

442

443

444

445

446

447

448

449

450

451

452

453

454

455

456

457

458

459

460

461

462

463

464

465

466

467

468

469

470

471

472

473

474

475

476

477

478

479

480

481

482

483

484

485

486

487

488

489

490

491

492

493

494

495

496

497

498

499

500

501

502

503

504

505

506

507

508

509

510

511

512

513

514

515

516

517

518

519

520

521

522

523

524

525

/*****************************************************************************

Based on logging_to MMW.ino

Adapted by Anthony and Brian

from source by: Sara Damiano (sdamiano@stroudcenter.org)

Development Environment: PlatformIO

Hardware Platform: EnviroDIY Mayfly Arduino Datalogger

Software License: BSD-3.

and the EnviroDIY Development Team

This example sketch is written for ModularSensors library version 0.23.4

This shows most of the standard functions of the library at once.

DISCLAIMER:

THIS CODE IS PROVIDED "AS IS" - NO WARRANTY IS GIVEN.

*****************************************************************************/

// ==========================================================================

// Defines for the Arduino IDE

// In PlatformIO, set these build flags in your platformio.ini

// ==========================================================================

#ifndef TINY_GSM_RX_BUFFER

#define TINY_GSM_RX_BUFFER 512

#endif

#ifndef TINY_GSM_YIELD_MS

#define TINY_GSM_YIELD_MS 2

#endif

#ifndef MQTT_MAX_PACKET_SIZE

#define MQTT_MAX_PACKET_SIZE 240

#endif

// ==========================================================================

// Include the base required libraries

// ==========================================================================

#include <Arduino.h> // The base Arduino library

#include <EnableInterrupt.h> // for external and pin change interrupts

#include <LoggerBase.h> // The modular sensors library

// ==========================================================================

// Include libraries for OLED

// ==========================================================================

#include <Wire.h>

#include <SPI.h>

#include <Adafruit_Sensor.h>

#include <Adafruit_BME280.h>

#include <SDL_Arduino_SSD1306.h> // Modification of Adafruit_SSD1306 for ESP8266 compatibility

#include <AMAdafruit_GFX.h> // Needs a little change in original Adafruit library (See README.txt file)

#include <SPI.h> // For SPI comm (needed for not getting compile error)

// Create an instance of the OLED display

SDL_Arduino_SSD1306 display(4); // FOR I2C

#define SEALEVELPRESSURE_HPA (1013.25)

Adafruit_BME280 bme; // I2C

// ==========================================================================

// Data Logger Settings

// ==========================================================================

// The library version this example was written for|previously 0.23.11

const char *libraryVersion = "0.25.1";

// The name of this file

const char *sketchName = "WXSTN_Mini_Mobile.ino";

// Logger ID, also becomes the prefix for the name of the data file on SD card

const char *LoggerID = "WX001";

// How frequently (in minutes) to log data

const uint8_t loggingInterval = 15;

// Your logger's timezone.

const int8_t timeZone = -6; // Central Standard Time

// NOTE: Daylight savings time will not be applied! Please use standard time!

// ==========================================================================

// Primary Arduino-Based Board and Processor

// ==========================================================================

#include <sensors/ProcessorStats.h>

const long serialBaud = 115200; // Baud rate for the primary serial port for debugging

const int8_t greenLED = 8; // MCU pin for the green LED (-1 if not applicable)

const int8_t redLED = 9; // MCU pin for the red LED (-1 if not applicable)

const int8_t buttonPin = 21; // MCU pin for a button to use to enter debugging mode (-1 if not applicable)

const int8_t wakePin = A7; // MCU interrupt/alarm pin to wake from sleep

// Set the wake pin to -1 if you do not want the main processor to sleep.

// In a SAMD system where you are using the built-in rtc, set wakePin to 1

const int8_t sdCardPwrPin = -1; // MCU SD card power pin (-1 if not applicable)

const int8_t sdCardSSPin = 12; // MCU SD card chip select/slave select pin (must be given!)

const int8_t sensorPowerPin = 22; // MCU pin controlling main sensor power (-1 if not applicable)

// Create the main processor chip "sensor" - for general metadata

const char *mcuBoardVersion = "v0.5b";

ProcessorStats mcuBoard(mcuBoardVersion);

// ==========================================================================

// Wifi/Cellular Modem Settings

// ==========================================================================

// Create a reference to the serial port for the modem

// Extra hardware and software serial ports are created in the "Settings for Additional Serial Ports" section

HardwareSerial &modemSerial = Serial1; // Use hardware serial if possible

// AltSoftSerial &modemSerial = altSoftSerial; // For software serial if needed

// NeoSWSerial &modemSerial = neoSSerial1; // For software serial if needed

// Modem Pins - Describe the physical pin connection of your modem to your board

const int8_t modemVccPin = -2; // MCU pin controlling modem power (-1 if not applicable)

const int8_t modemStatusPin = 19; // MCU pin used to read modem status (-1 if not applicable)

const int8_t modemResetPin = 20; // MCU pin connected to modem reset pin (-1 if unconnected)

const int8_t modemSleepRqPin = 23; // MCU pin used for modem sleep/wake request (-1 if not applicable)

const int8_t modemLEDPin = redLED; // MCU pin connected an LED to show modem status (-1 if unconnected)

// Network connection information

const char *apn = "hologram"; // The APN for the gprs connection

#if not defined MS_BUILD_TESTING || defined MS_BUILD_TEST_XBEE_CELLULAR

// For any Digi Cellular XBee's

// NOTE: The u-blox based Digi XBee's (3G global and LTE-M global)

// are more stable used in bypass mode (below)

// The Telit based Digi XBees (LTE Cat1) can only use this mode.

#include <modems/DigiXBeeCellularTransparent.h>

const long modemBaud = 9600; // All XBee's use 9600 by default

const bool useCTSforStatus = false; // Flag to use the modem CTS pin for status

// NOTE: If possible, use the STATUS/SLEEP_not (XBee pin 13) for status, but

// the CTS pin can also be used if necessary

DigiXBeeCellularTransparent modemXBCT(&modemSerial,

modemVccPin, modemStatusPin, useCTSforStatus,

modemResetPin, modemSleepRqPin,

apn);

// Create an extra reference to the modem by a generic name (not necessary)

DigiXBeeCellularTransparent modem = modemXBCT;

#endif

// ==========================================================================

// Maxim DS3231 RTC (Real Time Clock)

// ==========================================================================

#include <sensors/MaximDS3231.h>

// ==========================================================================

// Bosch BME280 Environmental Sensor (Temperature, Humidity, Pressure)

// ==========================================================================

#include <sensors/BoschBME280.h>

const int8_t I2CPower = sensorPowerPin; // Pin to switch power on and off (-1 if unconnected)

uint8_t BMEi2c_addr = 0x77;

// The BME280 can be addressed either as 0x77 (Adafruit default) or 0x76 (Grove default)

// Either can be physically mofidied for the other address

// Create a Bosch BME280 sensor object

BoschBME280 bme280(I2CPower, BMEi2c_addr);

// Create four variable pointers for the BME280

Variable *bme280Humid = new BoschBME280_Humidity(&bme280, "12345678-abcd-1234-ef00-1234567890ab");

Variable *bme280Temp = new BoschBME280_Temp(&bme280, "12345678-abcd-1234-ef00-1234567890ab");

Variable *bme280Press = new BoschBME280_Pressure(&bme280, "12345678-abcd-1234-ef00-1234567890ab");

Variable *bme280Alt = new BoschBME280_Altitude(&bme280, "12345678-abcd-1234-ef00-1234567890ab");

// Variable *bme280TempF = new CalcTempF(&bme280, "12345689-abcd-1234-ef00-1234567890ab");

// Create a DS3231 sensor object

MaximDS3231 ds3231(1);

// ==========================================================================

// Maxim DS18 One Wire Temperature Sensor

// ==========================================================================

#include <sensors/MaximDS18.h>

// OneWire Address [array of 8 hex characters]

// If only using a single sensor on the OneWire bus, you may omit the address

// DeviceAddress OneWireAddress1 = {0x28, 0xFF, 0xBD, 0xBA, 0x81, 0x16, 0x03, 0x0C};

const int8_t OneWirePower = sensorPowerPin; // Pin to switch power on and off (-1 if unconnected)

const int8_t OneWireBus = 7; // Pin attached to the OneWire Bus (-1 if unconnected) (D24 = A0)

// Create a Maxim DS18 sensor objects (use this form for a known address)

MaximDS18 ds18(OneWirePower, OneWireBus);

// Create a Maxim DS18 sensor object (use this form for a single sensor on bus with an unknown address)

// MaximDS18 ds18(OneWirePower, OneWireBus);

// Create a temperature variable pointer for the DS18

Variable *ds18Temp = new MaximDS18_Temp(&ds18, "12345678-abcd-1234-ef00-1234567890ab");

// ==========================================================================

// Calculated Variables

// ==========================================================================

// Create the function to convert the BME280 celcius to fahrenheit

// Variable *bme280TempF = new BoshBME280_TempF(&bme280, "12345689-abcd-1234-ef00-1234567890ab");

float calculateTempF(void)

{

float TempCFromMaximDS18_Temp = ds18Temp->getValue();

float TempF = TempCFromMaximDS18_Temp*(1.8)+32;

if (TempCFromMaximDS18_Temp == -9999)

{

TempF = -9999;

}

return TempF;

}

// Properties of the calculated temperature variable

const char *TempFVarName = "Temperature";

const char *TempFVarUnit = "Degree";

int TempFVarResolution = 2;

const char *TempFUUID = "12345678-abcd-1234-ef00-1234567890ab";

const char *TempFVarCode = "CalcTempF";

// Create the calculated fahrenheit variable object and return a variable pointer to it

Variable *CalcTempF = new Variable(calculateTempF, TempFVarResolution,

TempFVarName, TempFVarUnit,

TempFVarCode, TempFUUID);

/* CtoF - example from the internet

float CtoF(float cel){

float fahrenheit = (cel * 1.8) + 32;

return fahrenheit;

}

void printValues() {

Serial.print("Temperature = ");

float cel = bme.readTemperature();

Serial.print (bme.readTemperature());

Serial.println("C");

Serial.print(CtoF(cel));

Serial.println("F");

}

End CtoF - example from internet*/

// ==========================================================================

// Creating the Variable Array[s] and Filling with Variable Objects

// ==========================================================================

Variable *variableList[] = {

// new ProcessorStats_SampleNumber(&mcuBoard, "12345678-abcd-1234-ef00-1234567890ab"),

new ProcessorStats_Battery(&mcuBoard, "b17cb0f2-5538-4790-8641-39f416d185a3"),

new Modem_RSSI(&modem, "e1788d85-f8ca-451f-af49-5d4068650a04"),

new Modem_SignalPercent(&modem, "94c67feb-ade1-42eb-aef2-dcb021b85ef4"),

// new MaximDS3231_Temp(&ds3231, "3a304193-2e51-49e8-96a5-41015b445484"),

// new RainCounterI2C_Tips(&tbi2c, "12345678-abcd-1234-ef00-1234567890ab"),

new MaximDS18_Temp(&ds18, "a212b5a8-8ab3-456a-8e0e-c8647fe81772"),

new BoschBME280_Humidity(&bme280, "fb3cb409-fdc3-42e4-9881-2ee06ad4a4d7"),

new BoschBME280_Temp(&bme280, "d7b3ba33-8742-4c91-ac2e-8042e76b8f61"),

new CalcTempF(&ds18, "12345689-abcd-1234-ef00-1234567890ab"),

new BoschBME280_Pressure(&bme280, "252df794-5f34-4d70-b275-9a908c905b18"),

new BoschBME280_Altitude(&bme280, "09fe0223-e9ea-4937-93d7-3468bad920cd"),

};

// Count up the number of pointers in the array

int variableCount = sizeof(variableList) / sizeof(variableList[0]);

// Create the VariableArray object

VariableArray varArray(variableCount, variableList);

// ==========================================================================

// The Logger Object[s]

// ==========================================================================

// Create a new logger instance

Logger dataLogger(LoggerID, loggingInterval, &varArray);

// ==========================================================================

// A Publisher to Monitor My Watershed / EnviroDIY Data Sharing Portal

// ==========================================================================

// Device registration and sampling feature information can be obtained after

// registration at https://monitormywatershed.org or https://data.envirodiy.org

const char *registrationToken = "ffb78d86-af9e-426d-ad44-b807f9e0cd4a"; // Device registration token

const char *samplingFeature = "f5290c01-05a9-4047-b096-ca21f21bfbdd"; // Sampling feature UUID

// Create a data publisher for the EnviroDIY/WikiWatershed POST endpoint

#include <publishers/EnviroDIYPublisher.h>

EnviroDIYPublisher EnviroDIYPOST(dataLogger, &modem.gsmClient, registrationToken, samplingFeature);

// ==========================================================================

// Working Functions

// ==========================================================================

// Flashes the LED's on the primary board

void greenredflash(uint8_t numFlash = 4, uint8_t rate = 75)

{

for (uint8_t i = 0; i < numFlash; i++) {

digitalWrite(greenLED, HIGH);

digitalWrite(redLED, LOW);

delay(rate);

digitalWrite(greenLED, LOW);

digitalWrite(redLED, HIGH);

delay(rate);

}

digitalWrite(redLED, LOW);

}

// Read's the battery voltage

// NOTE: This will actually return the battery level from the previous update!

float getBatteryVoltage()

{

if (mcuBoard.sensorValues[0] == -9999) mcuBoard.update();

return mcuBoard.sensorValues[0];

}

unsigned long delayTime;

// ==========================================================================

// Main setup function

// ==========================================================================

void setup()

{

// Wait for USB connection to be established by PC

// NOTE: Only use this when debugging - if not connected to a PC, this

// could prevent the script from starting

// #if defined SERIAL_PORT_USBVIRTUAL

// while (!SERIAL_PORT_USBVIRTUAL && (millis() < 10000)){}

// #endif

// Start the primary serial connection

Serial.begin(serialBaud);

//Added from Example_06_Mayfly_BME280_OLED START

//Serial.println(F("BME280 test"));

// pinMode(5, INPUT);

pinMode(5, INPUT);

display.begin(SSD1306_SWITCHCAPVCC, 0x3C, false); // initialize with the I2C addr 0x3C (for the 128x64)

/**

display.clearDisplay();

display.setTextSize(2);

display.setTextColor(WHITE);

display.setCursor(0,0);

display.println("Mayfly");

display.println("BME280 DEMO...");

display.display();

/**

display.begin(SSD1306_SWITCHCAPVCC, 0x3C, false); // initialize with the I2C addr 0x3C (for the 128x64)

display.clearDisplay();

display.setTextSize(1);

display.setTextColor(WHITE, BLACK);

display.setTextColor(WHITE);

display.setCursor(0,0);

display.println("Mobile Mini Weather");

display.println("What's the Temp?");

display.println("*");

display.setTextSize(1);

display.setTextColor(WHITE, BLACK);

display.println("MMWX 808");

display.println("Location Unknown");

display.setTextSize(2);

display.println("72 degrees and sunny");

display.println("hi");

display.display();

**/

// Turn on switched power

pinMode(I2CPower, OUTPUT);

digitalWrite(I2CPower, HIGH);

bool status;

// default settings

// (you can also pass in a Wire library object like &Wire2)

status = bme.begin(BMEi2c_addr);

if (!status) {

Serial.println("Could not find a valid BME280 sensor, check wiring!");

while (1);

}

/**

Serial.println("-- Timing Test --");

delayTime = 1100;

Serial.println();

// Print table headers

Serial.println(" Time, Temp, Humid, Press, Alt");

Serial.println(" ms, *C, %, Pa, m");

//END added from Example_06_Mayfly_BME280_OLED

**/

// Print a start-up note to the first serial port

Serial.print(F("Now running "));

Serial.print(sketchName);

Serial.print(F(" on Logger "));

Serial.println(LoggerID);

Serial.println();

Serial.print(F("Using ModularSensors Library version "));

Serial.println(MODULAR_SENSORS_VERSION);

if (String(MODULAR_SENSORS_VERSION) != String(libraryVersion))

Serial.println(F(

"WARNING: THIS EXAMPLE WAS WRITTEN FOR A DIFFERENT VERSION OF MODULAR SENSORS!!"));

// Allow interrupts for software serial

#if defined SoftwareSerial_ExtInts_h

enableInterrupt(softSerialRx, SoftwareSerial_ExtInts::handle_interrupt, CHANGE);

#endif

#if defined NeoSWSerial_h

enableInterrupt(neoSSerial1Rx, neoSSerial1ISR, CHANGE);

#endif

// Start the serial connection with the modem

modemSerial.begin(modemBaud);

// Set up pins for the LED's

pinMode(greenLED, OUTPUT);

digitalWrite(greenLED, LOW);

pinMode(redLED, OUTPUT);

digitalWrite(redLED, LOW);

// Blink the LEDs to show the board is on and starting up

greenredflash();

// Set up some of the power pins so the board boots up with them off

// NOTE: This isn't necessary at all. The logger begin() function

// should leave all power pins off when it finishes.

/**

if (modemVccPin >= 0)

{

pinMode(modemVccPin, OUTPUT);

digitalWrite(modemVccPin, LOW);

}

if (sensorPowerPin >= 0)

{

pinMode(sensorPowerPin, OUTPUT);

digitalWrite(sensorPowerPin, LOW);

}

**/

// Set the timezones for the logger/data and the RTC

// Logging in the given time zone

Logger::setLoggerTimeZone(timeZone);

// It is STRONGLY RECOMMENDED that you set the RTC to be in UTC (UTC+0)

Logger::setRTCTimeZone(-6);

// Attach the modem and information pins to the logger

dataLogger.attachModem(modem);

modem.setModemLED(modemLEDPin);

dataLogger.setLoggerPins(wakePin, sdCardSSPin, sdCardPwrPin, buttonPin, greenLED);

// Begin the logger

dataLogger.begin();

// Note: Please change these battery voltages to match your battery

// Check that the battery is OK before powering the modem

if (getBatteryVoltage() > 3.7)

{

modem.modemPowerUp();

modem.wake();

modem.setup();

// At very good battery voltage, or with suspicious time stamp, sync the clock

// Note: Please change these battery voltages to match your battery

if (getBatteryVoltage() > 3.8 ||

dataLogger.getNowEpoch() < 1546300800 || /*Before 01/01/2019*/

dataLogger.getNowEpoch() > 1735689600) /*After 1/1/2025*/

{

// Synchronize the RTC with NIST

Serial.println(F("Attempting to connect to the internet and synchronize RTC with NIST"));

if (modem.connectInternet(120000L))

{

dataLogger.setRTClock(modem.getNISTTime());

}

else

{

Serial.println(F("Could not connect to internet for clock sync."));

}

// Set up the sensors, except at lowest battery level

if (getBatteryVoltage() > 3.4)

{

Serial.println(F("Setting up sensors..."));

varArray.setupSensors();

}

// Power down the modem

modem.disconnectInternet();

modem.modemSleepPowerDown();

// Create the log file, adding the default header to it

// Do this last so we have the best chance of getting the time correct and

// all sensor names correct

// Writing to the SD card can be power intensive, so if we're skipping

// the sensor setup we'll skip this too.

if (getBatteryVoltage() > 3.4)

{

dataLogger.turnOnSDcard(true); // true = wait for card to settle after power up

dataLogger.createLogFile(true); // true = write a new header

dataLogger.turnOffSDcard(true); // true = wait for internal housekeeping after write

}

// Call the processor sleep

Serial.println(F("Putting processor to sleep"));

dataLogger.systemSleep();

}

// ==========================================================================

// Main loop function

// ==========================================================================

// Use this short loop for simple data logging and sending

void loop()

{

if (getBatteryVoltage() > 3.6)

// for (int i=0; i <= 30; i++)

{

display.clearDisplay();

display.setTextSize(2);

display.setTextColor(WHITE);

display.setCursor(0,0);

// display.print("T: "); display.print(sensors.getTempCByIndex(0)); display.println(" C");

display.print("T: "); display.print(bme.readTemperature()); display.println(" C");

display.print("H: "); display.print(bme.readHumidity()); display.println(" %");

display.print("E:"); display.print(bme.readAltitude(SEALEVELPRESSURE_HPA)); display.println(" M");

display.setTextSize(1);

display.print("P: "); display.print(bme.readPressure()); display.println(" Pa");

display.display();

}

// Note: Please change these battery voltages to match your battery

// At very low battery, just go back to sleep

if (getBatteryVoltage() < 3.4)

{

dataLogger.systemSleep();

}

// At moderate voltage, log data but don't send it over the modem

else if (getBatteryVoltage() < 3.6)

{

dataLogger.logData();

}

// If the battery is good, send the data to the world

else

{

dataLogger.logDataAndPublish();

}

More...

2021-02-12 at 12:04 PM #15134
Sara Damiano
Moderator
In line 237 you don’t need the “new” or anything else with the calcTempF.

Replace new CalcTempF(&ds18, "12345689-abcd-1234-ef00-1234567890ab"), with just Calc

In line 237 you don’t need the “new” or anything else with the calcTempF.

Replace new CalcTempF(&ds18, "12345689-abcd-1234-ef00-1234567890ab"), with just CalcTempF,

You’ve already created and named the variable, so you don’t need to re-create it, just reference it. Actually, since you’ve created all your variables with names, you should reference all of them that way instead of creating a second identical one for each of them. So in your variable array, you can replace almost all of the new ... with the names you gave the variables in the sensor blocks. The result will look more like the VariableArray in the data saving example: https://github.com/EnviroDIY/ModularSensors/blob/149bb59cdb34f7d54d26cd4a81b7e7a90eabced8/examples/data_saving/data_saving.ino#L318

More...

Less...
2021-02-12 at 12:07 PM #15135
Sara Damiano
Moderator
Does that make sense?

So, for example, in line 178 you created a variable for the DS18 (Variable *ds18Temp = new MaximDS18_Temp(&ds18, "12345678-abcd-1234-ef00-1234567890ab");) Since

Does that make sense?

So, for example, in line 178 you created a variable for the DS18 (Variable *ds18Temp = new MaximDS18_Temp(&ds18, "12345678-abcd-1234-ef00-1234567890ab");) Since you’ve already done that, down in line 234 instead you can replace new MaximDS18_Temp(&ds18, "12345678-abcd-1234-ef00-1234567890ab"), with just ds18Temp,. And you can do the same with all of the other variables.

More...

Less...
2021-02-12 at 12:59 PM #15138
BrianJastram
Participant
Awesome, thank you. That solved the error. I was wondering about my variable array because I saw the format of the variable array in the baro_rho_correction sketch and it was more bare bones.
Now I

Awesome, thank you. That solved the error. I was wondering about my variable array because I saw the format of the variable array in the baro_rho_correction sketch and it was more bare bones.
Now I’m puzzling on the -17966.20 Degree F output I’m seeing in the serial monitor. I tried adding true to the ds18->getValue(true) but that didn’t work.

More...

Less...
2021-02-12 at 1:11 PM #15139
BrianJastram
Participant
Now I got it to be 33.8 F by replacing
float TempF = TempCFromMaxiumDS18_Temp*1.8+32 with
float TempF = true*1.8+32
2021-02-12 at 1:15 PM #15140
Sara Damiano
Moderator
-17966.20 does seem a little bit cold for most offices. Did you change your variable array so it has the ds18Temp named variable in it instead of the other new variable? If not update

-17966.20 does seem a little bit cold for most offices. Did you change your variable array so it has the ds18Temp named variable in it instead of the other new variable? If not update step will update that other new variable and not the one that you’re calculating F from, though adding the “true” to the getValue should force it to update anyway. Is the Celsius temperature from the DS18 reasonable?

Using true*1.8+32 will give you 33.8 no matter what happens. In the multiplication “true” is converted to “1” so your equation is just (1*1.8)+32 = 33.8.

More...

Less...
2021-02-12 at 1:18 PM #15141
Sara Damiano
Moderator
You can throw a Serial.println(TempCFromMaxiumDS18_Temp); into the middle of your calculation equation just for testing. I can try testing your code myself later this afternoon.
2021-02-12 at 1:26 PM #15142
BrianJastram
Participant
I tried just DS18Temp but that didn’t work.
The Celsius temperature from the DS18 is a reasonable 22.25 degrees.
2021-02-12 at 1:53 PM #15143
Sara Damiano
Moderator
Hm. Can you post your current code? I’ll try running it. I have a DS18 here so hopefully once I attach things and start trying to run them whatever issue I’m missing will jump out at m

Hm. Can you post your current code? I’ll try running it. I have a DS18 here so hopefully once I attach things and start trying to run them whatever issue I’m missing will jump out at me.

More...

Less...

2021-02-12 at 2:17 PM #15144

BrianJastram

Participant

Yes, thank you. Here it is.

/*****************************************************************************
Based on logging_to MMW.ino
Adapted by Anthony and B

/*****************************************************************************

Based on logging_to MMW.ino

Adapted by Anthony and B

Yes, thank you. Here it is.

/*****************************************************************************
Based on logging_to MMW.ino
Adapted by Anthony and Brian
from source by:  Sara Damiano (sdamiano@stroudcenter.org)
Development Environment: PlatformIO
Hardware Platform: EnviroDIY Mayfly Arduino Datalogger
Software License: BSD-3.
  Copyright (c) 2017, Stroud Water Research Center (SWRC)
  and the EnviroDIY Development Team

This example sketch is written for ModularSensors library version 0.23.4

This shows most of the standard functions of the library at once.

DISCLAIMER:
THIS CODE IS PROVIDED "AS IS" - NO WARRANTY IS GIVEN.
*****************************************************************************/

// ==========================================================================
//    Defines for the Arduino IDE
//    In PlatformIO, set these build flags in your platformio.ini
// ==========================================================================
#ifndef TINY_GSM_RX_BUFFER
#define TINY_GSM_RX_BUFFER 512
#endif
#ifndef TINY_GSM_YIELD_MS
#define TINY_GSM_YIELD_MS 2
#endif
#ifndef MQTT_MAX_PACKET_SIZE
#define MQTT_MAX_PACKET_SIZE 240
#endif

// ==========================================================================
//    Include the base required libraries
// ==========================================================================
#include <Arduino.h>  // The base Arduino library
#include <EnableInterrupt.h>  // for external and pin change interrupts
#include <LoggerBase.h>  // The modular sensors library

// ==========================================================================
//    Include libraries for OLED
// ==========================================================================
#include <Wire.h>
#include <SPI.h>
#include <Adafruit_Sensor.h>
#include <Adafruit_BME280.h>
#include <SDL_Arduino_SSD1306.h>    // Modification of Adafruit_SSD1306 for ESP8266 compatibility
#include <AMAdafruit_GFX.h>   // Needs a little change in original Adafruit library (See README.txt file)
#include <SPI.h>            // For SPI comm (needed for not getting compile error)

// Create an instance of the OLED display
SDL_Arduino_SSD1306 display(4); // FOR I2C

#define SEALEVELPRESSURE_HPA (1013.25)

Adafruit_BME280 bme; // I2C

// ==========================================================================
//    Data Logger Settings
// ==========================================================================
// The library version this example was written for|previously 0.23.11
const char *libraryVersion = "0.25.1";
// The name of this file
const char *sketchName = "WXSTN_Mini_Mobile.ino";
// Logger ID, also becomes the prefix for the name of the data file on SD card
const char *LoggerID = "WX001";
// How frequently (in minutes) to log data
const uint8_t loggingInterval = 15;
// Your logger's timezone.
const int8_t timeZone = -6;  // Central Standard Time
// NOTE:  Daylight savings time will not be applied!  Please use standard time!

// ==========================================================================
//    Primary Arduino-Based Board and Processor
// ==========================================================================
#include <sensors/ProcessorStats.h>

const long serialBaud = 115200;   // Baud rate for the primary serial port for debugging
const int8_t greenLED = 8;        // MCU pin for the green LED (-1 if not applicable)
const int8_t redLED = 9;          // MCU pin for the red LED (-1 if not applicable)
const int8_t buttonPin = 21;      // MCU pin for a button to use to enter debugging mode  (-1 if not applicable)
const int8_t wakePin = A7;        // MCU interrupt/alarm pin to wake from sleep
// Set the wake pin to -1 if you do not want the main processor to sleep.
// In a SAMD system where you are using the built-in rtc, set wakePin to 1
const int8_t sdCardPwrPin = -1;     // MCU SD card power pin (-1 if not applicable)
const int8_t sdCardSSPin = 12;      // MCU SD card chip select/slave select pin (must be given!)
const int8_t sensorPowerPin = 22;  // MCU pin controlling main sensor power (-1 if not applicable)

// Create the main processor chip "sensor" - for general metadata
const char *mcuBoardVersion = "v0.5b";
ProcessorStats mcuBoard(mcuBoardVersion);

// ==========================================================================
//    Wifi/Cellular Modem Settings
// ==========================================================================

// Create a reference to the serial port for the modem
// Extra hardware and software serial ports are created in the "Settings for Additional Serial Ports" section
HardwareSerial &modemSerial = Serial1;  // Use hardware serial if possible
// AltSoftSerial &modemSerial = altSoftSerial;  // For software serial if needed
// NeoSWSerial &modemSerial = neoSSerial1;  // For software serial if needed

// Modem Pins - Describe the physical pin connection of your modem to your board
const int8_t modemVccPin = -2;      // MCU pin controlling modem power (-1 if not applicable)
const int8_t modemStatusPin = 19;   // MCU pin used to read modem status (-1 if not applicable)
const int8_t modemResetPin = 20;    // MCU pin connected to modem reset pin (-1 if unconnected)
const int8_t modemSleepRqPin = 23;  // MCU pin used for modem sleep/wake request (-1 if not applicable)
const int8_t modemLEDPin = redLED;  // MCU pin connected an LED to show modem status (-1 if unconnected)

// Network connection information
const char *apn = "hologram";  // The APN for the gprs connection

#if not defined MS_BUILD_TESTING || defined MS_BUILD_TEST_XBEE_CELLULAR
// For any Digi Cellular XBee's
// NOTE:  The u-blox based Digi XBee's (3G global and LTE-M global)
// are more stable used in bypass mode (below)
// The Telit based Digi XBees (LTE Cat1) can only use this mode.
#include <modems/DigiXBeeCellularTransparent.h>
const long modemBaud = 9600;  // All XBee's use 9600 by default
const bool useCTSforStatus = false;   // Flag to use the modem CTS pin for status
// NOTE:  If possible, use the STATUS/SLEEP_not (XBee pin 13) for status, but
// the CTS pin can also be used if necessary
DigiXBeeCellularTransparent modemXBCT(&modemSerial,
                                      modemVccPin, modemStatusPin, useCTSforStatus,
                                      modemResetPin, modemSleepRqPin,
                                      apn);
// Create an extra reference to the modem by a generic name (not necessary)
DigiXBeeCellularTransparent modem = modemXBCT;

#endif

// ==========================================================================
//    Maxim DS3231 RTC (Real Time Clock)
// ==========================================================================
#include <sensors/MaximDS3231.h>

// ==========================================================================
//    Bosch BME280 Environmental Sensor (Temperature, Humidity, Pressure)
// ==========================================================================
#include <sensors/BoschBME280.h>

const int8_t I2CPower = sensorPowerPin;  // Pin to switch power on and off (-1 if unconnected)
uint8_t BMEi2c_addr = 0x77;
// The BME280 can be addressed either as 0x77 (Adafruit default) or 0x76 (Grove default)
// Either can be physically mofidied for the other address

// Create a Bosch BME280 sensor object
BoschBME280 bme280(I2CPower, BMEi2c_addr);

// Create four variable pointers for the BME280
Variable *bme280Humid = new BoschBME280_Humidity(&bme280, "12345678-abcd-1234-ef00-1234567890ab");
Variable *bme280Temp = new BoschBME280_Temp(&bme280, "12345678-abcd-1234-ef00-1234567890ab");
Variable *bme280Press = new BoschBME280_Pressure(&bme280, "12345678-abcd-1234-ef00-1234567890ab");
Variable *bme280Alt = new BoschBME280_Altitude(&bme280, "12345678-abcd-1234-ef00-1234567890ab");
// Variable *bme280TempF = new CalcTempF(&bme280, "12345689-abcd-1234-ef00-1234567890ab");

// Create a DS3231 sensor object
MaximDS3231 ds3231(1);

// ==========================================================================
//    Maxim DS18 One Wire Temperature Sensor
// ==========================================================================
#include <sensors/MaximDS18.h>

// OneWire Address [array of 8 hex characters]
// If only using a single sensor on the OneWire bus, you may omit the address
// DeviceAddress OneWireAddress1 = {0x28, 0xFF, 0xBD, 0xBA, 0x81, 0x16, 0x03, 0x0C};
const int8_t OneWirePower = sensorPowerPin;  // Pin to switch power on and off (-1 if unconnected)
const int8_t OneWireBus = 7;  // Pin attached to the OneWire Bus (-1 if unconnected) (D24 = A0)

// Create a Maxim DS18 sensor objects (use this form for a known address)
MaximDS18 ds18(OneWirePower, OneWireBus);

// Create a Maxim DS18 sensor object (use this form for a single sensor on bus with an unknown address)
// MaximDS18 ds18(OneWirePower, OneWireBus);

// Create a temperature variable pointer for the DS18
Variable *ds18Temp = new MaximDS18_Temp(&ds18, "12345678-abcd-1234-ef00-1234567890ab");


// ==========================================================================
//    Calculated Variables
// ==========================================================================
// Create the function to convert the BME280 celcius to fahrenheit
// Variable *bme280TempF = new BoshBME280_TempF(&bme280, "12345689-abcd-1234-ef00-1234567890ab");
float calculateTempF(void)
{
    float TempCFromMaximDS18_Temp = ds18Temp->getValue(true);
    float TempF = (true)*1.8+32;
    //if (TempCFromMaximDS18_Temp == -9999)
    //{
    //    TempF = -9999;
    //}
    Serial.println(TempCFromMaxiumDS18_Temp);
    return TempF;
}
// Properties of the calculated temperature variable
const char *TempFVarName = "DS18 CalcTempF";
const char *TempFVarUnit = "Degrees F";
int TempFVarResolution = 1;
const char *TempFUUID = "12345678-abcd-1234-ef00-1234567890ab";
const char *TempFVarCode = "CalcTempF";
// Create the calculated fahrenheit variable object and return a variable pointer to it
Variable *CalcTempF = new Variable(calculateTempF, TempFVarResolution,
                                   TempFVarName, TempFVarUnit,
                                   TempFVarCode, TempFUUID);

/* CtoF - example from the internet
float CtoF(float cel){
  float fahrenheit = (cel * 1.8) + 32;
  return fahrenheit;
}

void printValues() {
    Serial.print("Temperature = ");
    float cel = bme.readTemperature();
    Serial.print (bme.readTemperature());
    Serial.println("C");
    Serial.print(CtoF(cel));
    Serial.println("F");
}
 End CtoF - example from internet*/

// ==========================================================================
//    Creating the Variable Array[s] and Filling with Variable Objects
// ==========================================================================

Variable *variableList[] = {
    // new ProcessorStats_SampleNumber(&mcuBoard, "12345678-abcd-1234-ef00-1234567890ab"),
    new ProcessorStats_Battery(&mcuBoard, "b17cb0f2-5538-4790-8641-39f416d185a3"),
    new Modem_RSSI(&modem, "e1788d85-f8ca-451f-af49-5d4068650a04"),
    new Modem_SignalPercent(&modem, "94c67feb-ade1-42eb-aef2-dcb021b85ef4"),
    // new MaximDS3231_Temp(&ds3231, "3a304193-2e51-49e8-96a5-41015b445484"),
    // new RainCounterI2C_Tips(&tbi2c, "12345678-abcd-1234-ef00-1234567890ab"),
    new MaximDS18_Temp(&ds18, "a212b5a8-8ab3-456a-8e0e-c8647fe81772"),
    new BoschBME280_Humidity(&bme280, "fb3cb409-fdc3-42e4-9881-2ee06ad4a4d7"),
    new BoschBME280_Temp(&bme280, "d7b3ba33-8742-4c91-ac2e-8042e76b8f61"),
    CalcTempF,
    new BoschBME280_Pressure(&bme280, "252df794-5f34-4d70-b275-9a908c905b18"),
    new BoschBME280_Altitude(&bme280, "09fe0223-e9ea-4937-93d7-3468bad920cd"),
};

// Count up the number of pointers in the array
int variableCount = sizeof(variableList) / sizeof(variableList[0]);

// Create the VariableArray object
VariableArray varArray(variableCount, variableList);

// ==========================================================================
//     The Logger Object[s]
// ==========================================================================

// Create a new logger instance
Logger dataLogger(LoggerID, loggingInterval, &varArray);

// ==========================================================================
//    A Publisher to Monitor My Watershed / EnviroDIY Data Sharing Portal
// ==========================================================================
// Device registration and sampling feature information can be obtained after
// registration at https://monitormywatershed.org or https://data.envirodiy.org
const char *registrationToken = "ffb78d86-af9e-426d-ad44-b807f9e0cd4a";   // Device registration token
const char *samplingFeature = "f5290c01-05a9-4047-b096-ca21f21bfbdd";     // Sampling feature UUID

// Create a data publisher for the EnviroDIY/WikiWatershed POST endpoint
#include <publishers/EnviroDIYPublisher.h>
EnviroDIYPublisher EnviroDIYPOST(dataLogger, &modem.gsmClient, registrationToken, samplingFeature);

// ==========================================================================
//    Working Functions
// ==========================================================================

// Flashes the LED's on the primary board
void greenredflash(uint8_t numFlash = 4, uint8_t rate = 75)
{
    for (uint8_t i = 0; i < numFlash; i++) {
        digitalWrite(greenLED, HIGH);
        digitalWrite(redLED, LOW);
        delay(rate);
        digitalWrite(greenLED, LOW);
        digitalWrite(redLED, HIGH);
        delay(rate);
    }
    digitalWrite(redLED, LOW);
}

// Read's the battery voltage
// NOTE: This will actually return the battery level from the previous update!
float getBatteryVoltage()
{
    if (mcuBoard.sensorValues[0] == -9999) mcuBoard.update();
    return mcuBoard.sensorValues[0];
}

unsigned long delayTime;

// ==========================================================================
// Main setup function
// ==========================================================================
void setup()
{
    // Wait for USB connection to be established by PC
    // NOTE:  Only use this when debugging - if not connected to a PC, this
    // could prevent the script from starting
    // #if defined SERIAL_PORT_USBVIRTUAL
    //   while (!SERIAL_PORT_USBVIRTUAL && (millis() < 10000)){}
    // #endif

    // Start the primary serial connection
    Serial.begin(serialBaud);
    //Added from Example_06_Mayfly_BME280_OLED START
    //Serial.println(F("BME280 test"));

    // pinMode(5, INPUT);
    pinMode(5, INPUT);
    display.begin(SSD1306_SWITCHCAPVCC, 0x3C, false);  // initialize with the I2C addr 0x3C (for the 128x64)
    /**
    display.clearDisplay();
    display.setTextSize(2);
    display.setTextColor(WHITE);
    display.setCursor(0,0);
    display.println("Mayfly");
    display.println("BME280 DEMO...");
    display.display();
    /**
    display.begin(SSD1306_SWITCHCAPVCC, 0x3C, false);  // initialize with the I2C addr 0x3C (for the 128x64)
    display.clearDisplay();
    display.setTextSize(1);
    display.setTextColor(WHITE, BLACK);
    display.setTextColor(WHITE);
    display.setCursor(0,0);
    display.println("Mobile Mini Weather");
    display.println("What's the Temp?");
    display.println("*");
    display.setTextSize(1);
    display.setTextColor(WHITE, BLACK);
    display.println("MMWX 808");
    display.println("Location Unknown");
    display.setTextSize(2);
    display.println("72 degrees and sunny");
    display.println("hi");
    display.display();
    **/
    // Turn on switched power
    pinMode(I2CPower, OUTPUT);
    digitalWrite(I2CPower, HIGH);

    bool status;

    // default settings
    // (you can also pass in a Wire library object like &Wire2)
    status = bme.begin(BMEi2c_addr);
    if (!status) {
        Serial.println("Could not find a valid BME280 sensor, check wiring!");
        while (1);
    }
/**
    Serial.println("-- Timing Test --");
    delayTime = 1100;

    Serial.println();

    // Print table headers
    Serial.println("  Time,  Temp, Humid,   Press,   Alt");
    Serial.println("    ms,    *C,     %,      Pa,     m");
    //END added from Example_06_Mayfly_BME280_OLED
**/
    // Print a start-up note to the first serial port
    Serial.print(F("Now running "));
    Serial.print(sketchName);
    Serial.print(F(" on Logger "));
    Serial.println(LoggerID);
    Serial.println();

    Serial.print(F("Using ModularSensors Library version "));
    Serial.println(MODULAR_SENSORS_VERSION);

    if (String(MODULAR_SENSORS_VERSION) !=  String(libraryVersion))
        Serial.println(F(
            "WARNING: THIS EXAMPLE WAS WRITTEN FOR A DIFFERENT VERSION OF MODULAR SENSORS!!"));

    // Allow interrupts for software serial
    #if defined SoftwareSerial_ExtInts_h
        enableInterrupt(softSerialRx, SoftwareSerial_ExtInts::handle_interrupt, CHANGE);
    #endif
    #if defined NeoSWSerial_h
        enableInterrupt(neoSSerial1Rx, neoSSerial1ISR, CHANGE);
    #endif

    // Start the serial connection with the modem
    modemSerial.begin(modemBaud);


    // Set up pins for the LED's
    pinMode(greenLED, OUTPUT);
    digitalWrite(greenLED, LOW);
    pinMode(redLED, OUTPUT);
    digitalWrite(redLED, LOW);
    // Blink the LEDs to show the board is on and starting up
    greenredflash();

    // Set up some of the power pins so the board boots up with them off
    // NOTE:  This isn't necessary at all.  The logger begin() function
    // should leave all power pins off when it finishes.

    /**
    if (modemVccPin >= 0)
    {
        pinMode(modemVccPin, OUTPUT);
        digitalWrite(modemVccPin, LOW);
    }
    if (sensorPowerPin >= 0)
    {
        pinMode(sensorPowerPin, OUTPUT);
        digitalWrite(sensorPowerPin, LOW);
    }
    **/

    // Set the timezones for the logger/data and the RTC
    // Logging in the given time zone
    Logger::setLoggerTimeZone(timeZone);
    // It is STRONGLY RECOMMENDED that you set the RTC to be in UTC (UTC+0)
    Logger::setRTCTimeZone(-6);

    // Attach the modem and information pins to the logger
    dataLogger.attachModem(modem);
    modem.setModemLED(modemLEDPin);
    dataLogger.setLoggerPins(wakePin, sdCardSSPin, sdCardPwrPin, buttonPin, greenLED);

    // Begin the logger
    dataLogger.begin();

    // Note:  Please change these battery voltages to match your battery
    // Check that the battery is OK before powering the modem
    if (getBatteryVoltage() > 3.7)
    {
        modem.modemPowerUp();
        modem.wake();
        modem.setup();

        // At very good battery voltage, or with suspicious time stamp, sync the clock
        // Note:  Please change these battery voltages to match your battery
        if (getBatteryVoltage() > 3.8 ||
            dataLogger.getNowEpoch() < 1546300800 ||  /*Before 01/01/2019*/
            dataLogger.getNowEpoch() > 1735689600)  /*After 1/1/2025*/
        {
            // Synchronize the RTC with NIST
            Serial.println(F("Attempting to connect to the internet and synchronize RTC with NIST"));
            if (modem.connectInternet(120000L))
            {
                dataLogger.setRTClock(modem.getNISTTime());
            }
            else
            {
                Serial.println(F("Could not connect to internet for clock sync."));
            }
        }
    }

    // Set up the sensors, except at lowest battery level
    if (getBatteryVoltage() > 3.4)
    {
        Serial.println(F("Setting up sensors..."));
        varArray.setupSensors();
    }

    // Power down the modem
    modem.disconnectInternet();
    modem.modemSleepPowerDown();

    // Create the log file, adding the default header to it
    // Do this last so we have the best chance of getting the time correct and
    // all sensor names correct
    // Writing to the SD card can be power intensive, so if we're skipping
    // the sensor setup we'll skip this too.
    if (getBatteryVoltage() > 3.4)
    {
        dataLogger.turnOnSDcard(true);  // true = wait for card to settle after power up
        dataLogger.createLogFile(true);  // true = write a new header
        dataLogger.turnOffSDcard(true);  // true = wait for internal housekeeping after write
    }
    // Call the processor sleep
    Serial.println(F("Putting processor to sleep"));
    dataLogger.systemSleep();
}


// ==========================================================================
// Main loop function
// ==========================================================================

// Use this short loop for simple data logging and sending
void loop()
{
  if (getBatteryVoltage() > 3.6)
  //    for (int i=0; i <= 30; i++)
  {
      display.clearDisplay();
      display.setTextSize(2);
      display.setTextColor(WHITE);
      display.setCursor(0,0);
      // display.print("T: "); display.print(sensors.getTempCByIndex(0)); display.println(" C");
      display.print("T: "); display.print(bme.readTemperature()); display.println(" C");
      display.print("H: "); display.print(bme.readHumidity()); display.println(" %");
      display.print("E:"); display.print(bme.readAltitude(SEALEVELPRESSURE_HPA)); display.println(" M");
      display.setTextSize(1);
      display.print("P: "); display.print(bme.readPressure()); display.println(" Pa");
      display.display();
    }
    // Note:  Please change these battery voltages to match your battery
    // At very low battery, just go back to sleep
    if (getBatteryVoltage() < 3.4)
    {
        dataLogger.systemSleep();
    }
    // At moderate voltage, log data but don't send it over the modem
    else if (getBatteryVoltage() < 3.6)
    {
        dataLogger.logData();
    }
    // If the battery is good, send the data to the world
    else
    {
        dataLogger.logDataAndPublish();
    }

}

100

101

102

103

104

105

106

107

108

109

110

111

112

113

114

115

116

117

118

119

120

121

122

123

124

125

126

127

128

129

130

131

132

133

134

135

136

137

138

139

140

141

142

143

144

145

146

147

148

149

150

151

152

153

154

155

156

157

158

159

160

161

162

163

164

165

166

167

168

169

170

171

172

173

174

175

176

177

178

179

180

181

182

183

184

185

186

187

188

189

190

191

192

193

194

195

196

197

198

199

200

201

202

203

204

205

206

207

208

209

210

211

212

213

214

215

216

217

218

219

220

221

222

223

224

225

226

227

228

229

230

231

232

233

234

235

236

237

238

239

240

241

242

243

244

245

246

247

248

249

250

251

252

253

254

255

256

257

258

259

260

261

262

263

264

265

266

267

268

269

270

271

272

273

274

275

276

277

278

279

280

281

282

283

284

285

286

287

288

289

290

291

292

293

294

295

296

297

298

299

300

301

302

303

304

305

306

307

308

309

310

311

312

313

314

315

316

317

318

319

320

321

322

323

324

325

326

327

328

329

330

331

332

333

334

335

336

337

338

339

340

341

342

343

344

345

346

347

348

349

350

351

352

353

354

355

356

357

358

359

360

361

362

363

364

365

366

367

368

369

370

371

372

373

374

375

376

377

378

379

380

381

382

383

384

385

386

387

388

389

390

391

392

393

394

395

396

397

398

399

400

401

402

403

404

405

406

407

408

409

410

411

412

413

414

415

416

417

418

419

420

421

422

423

424

425

426

427

428

429

430

431

432

433

434

435

436

437

438

439

440

441

442

443

444

445

446

447

448

449

450

451

452

453

454

455

456

457

458

459

460

461

462

463

464

465

466

467

468

469

470

471

472

473

474

475

476

477

478

479

480

481

482

483

484

485

486

487

488

489

490

491

492

493

494

495

496

497

498

499

500

501

502

503

504

505

506

507

508

509

510

511

512

513

514

515

516

517

518

519

520

521

522

523

524

525

526